test: add the DefaultEngine::write_parquet_from_filtered_batches test utility
#887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 84.98% 85.10% +0.11%
==========================================
Files 84 85 +1
Lines 20849 21151 +302
Branches 20849 21151 +302
==========================================
+ Hits 17718 18000 +282
+ Misses 2241 2238 -3
- Partials 890 913 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
the
breaking-change
sebastiantia
removed
the
breaking-change
github-actions
bot
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
DefaultEngine::write_parquet_from_filtered_batches. This is introduced to allow for:Snapshot::checkpoint()&Table::checkpoint()API #797) requires a way to write the checkpoint data returned by the engine - an iterator ofFilteredEngineDatabatches. For more information: (link to issue)checkpointAPI on theDefaultEnginewhich orchestrates the entire checkpointing process, from data creation, to finalization.Other changes:
write_parquet_from_batches: Refactors the writing logic fromwrite_parquetto support streaming data by accepting an iterator of batches instead of a single batch. This is leveraged bywrite_parquetand the newwrite_parquet_from_filtered_batcheswrite_parquet: Functionally the same. Simply refactored to callwrite_parquet_from_batchesunder the hood.